refactor(validator): narrow _sign_with_key return to Signature#980
Merged
tcoratger merged 1 commit intoJun 12, 2026
Merged
Conversation
The updated validator entry returned alongside the signature was never consumed: both call sites discarded it, and the registry is already updated in place before returning. Drop the dead tuple element and return the signature directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The signing helper in the validator service returned a
tuple[ValidatorEntry, Signature], but the updated entry was never used by any caller. Both call sites discarded it with_,, and the registry is already updated in place inside the helper before it returns. The wider return type was dead surface area.This narrows the return to
Signature:Returns:section accordingly.The type narrowing is validated by
ty;just checkpasses clean.Testing
uv run pytest tests/node/validator/test_service.py -q— 51 passed.just check— lint, format, typecheck, spell, mdformat all pass.🤖 Generated with Claude Code